Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new notifications: plugin_stopped and plugin_started #7508

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gudnuf
Copy link

@gudnuf gudnuf commented Jul 30, 2024

Send plugin_started when a plugin has completed startup and send plugin_stopped when a plugin is shutdown.

This PR follows the same motivations as #7507, and is the second piece of what will be required for other plugins such as clnrest to dynamically register and drop routes.

What's changed?

Added two new notifications: plugin_started and plugin_stopped

Updated the docs with the schemas for these notifications

Copy link
Collaborator

@niftynei niftynei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK 2034309

lightningd/notification.c Show resolved Hide resolved
@cdecker
Copy link
Member

cdecker commented Aug 8, 2024

ACK af35c0c

@cdecker cdecker force-pushed the plugin_stop_start_notifications branch from af35c0c to 5e9ec0e Compare December 6, 2024 10:53
@cdecker
Copy link
Member

cdecker commented Dec 6, 2024

Picking this up again, as it bitrotted away a bit.

@cdecker cdecker self-assigned this Dec 6, 2024
@cdecker cdecker added this to the v25.02 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants